Skip to content

refactor: Update wrong fluid fraction error message #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arng40 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

refactor: Update wrong fluid fraction error message #3917

arng40 wants to merge 8 commits into from
+225 −9

Conversation

@arng40
Copy link
Contributor

@arng40 arng40 commented Nov 27, 2025 •
edited
Loading

Update this error message

***** ERROR
***** LOCATION: path/to/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseBase.cpp:939
***** Error cause: totalWrongCompFrac > 0
***** Rank 0: 5 component fractions do not sum to 1.0 in subregion 'cb'!
5 are too low ; 0 are too high ; component fractions sum range is from 0 to 0.
Consider adding field specification to initialize the 'globalCompFraction' field.

@arng40 arng40 marked this pull request as ready for review November 27, 2025 13:38
@arng40 arng40 self-assigned this Nov 27, 2025
@arng40 arng40 added type: cleanup / refactor Non-functional change (NFC) flag: ready for review flag: no rebaseline Does not require rebaseline labels Nov 27, 2025
@MelReyCG MelReyCG changed the title refactor: Update initializeFluidState error message refactor: Update wrong fluid fraction error message Nov 27, 2025
MelReyCG
MelReyCG reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing some naming & information displaying improvements.

@arng40 arng40 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paveltomin paveltomin paveltomin approved these changes

@MelReyCG MelReyCG MelReyCG approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@herve-gross herve-gross Awaiting requested review from herve-gross herve-gross is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk is a code owner

@rasimHZ rasimHZ Awaiting requested review from rasimHZ rasimHZ is a code owner

Assignees

@arng40 arng40

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arng40 @paveltomin @MelReyCG